Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional #316

Merged
merged 3 commits into from
Oct 23, 2022
Merged

Add optional #316

merged 3 commits into from
Oct 23, 2022

Conversation

wietse-gmail
Copy link
Contributor

This adds missing [optional] annotations to flags in the verify-artifact --help message.

Alternatively, we could just indicate what flags are [required] - there are only two of them - and remove all the [optional] noise from all other flags.

Add missing [optional] indicators to the "verify-artifact" --help example.

Signed-off-by: Wietse Venema <72045954+wietse-gmail@users.noreply.github.com>
Signed-off-by: Wietse Venema <72045954+wietse-gmail@users.noreply.github.com>
Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianlewis ianlewis enabled auto-merge (squash) October 23, 2022 23:25
@ianlewis ianlewis merged commit 27597fe into slsa-framework:main Oct 23, 2022
@wietse-gmail wietse-gmail deleted the add-optional branch October 25, 2022 15:49
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants