Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make builder ID not compulsory for BYOB builders hosted on our repo #659

Closed
laurentsimon opened this issue Jul 14, 2023 · 3 comments · Fixed by #674
Closed

Make builder ID not compulsory for BYOB builders hosted on our repo #659

laurentsimon opened this issue Jul 14, 2023 · 3 comments · Fixed by #674
Labels
area:BYOB An issue with the BYOB delegated workflows
Milestone
BYOB

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Jul 14, 2023 •
edited by ianlewis
Loading

See original discussion in #656
/cc @enteraga6
@laurentsimon laurentsimon added the area:BYOB An issue with the BYOB delegated workflows label Jul 14, 2023
@laurentsimon laurentsimon added this to the BYOB milestone Jul 14, 2023
@laurentsimon laurentsimon mentioned this issue Jul 14, 2023
Closed
@enteraga6
Copy link
Contributor

original discussion in #656 and #657

@laurentsimon
Copy link
Contributor Author

Any luck on this feature, @enteraga6 ?

@enteraga6
Copy link
Contributor

@laurentsimon writing tests for it, then will pr

This was referenced Jul 28, 2023
Closed
Merged
laurentsimon added a commit that referenced this issue Aug 11, 2023
@enteraga6 @laurentsimon
feat: Non-compulsory BuilderID for BYOB Builders (#674)
8bcf1f0 
/cc @mihaimaruseac
/cc @laurentsimon 

Based off the prefix of the BuilderID within the provenance, if the
builder use to build the artifact is one of the BYOB builders of
slsa-framework/slsa-github-generator repo, the --builderid flag is not
need and is handled automatically. This was done to increase access to
users since before the automatic pickup of the builder-id would get the
delegator.

Test cases that cover verifyProvenance will need to be complete after
the v1.8.0 release of slsa-framework/slsa-github-generator.

The main structure that is changed is the ExpectedBuilderPath is
hardcoded now to slsa-framework builders within
`/cli/slsa-verifier/verify/verify_artifact.go `. This can later be
changed now if needed to be an input like the other fields of
`provenanceOpts` populated during `verify_artifact.go`. The added
function within `provenance.go`, `verifyBuilderIDPath` is called during
`verifyProvenance` to check this path within `provenanceOpts`. Upon
failure of this function, expected and received BuilderID's are also
outputted.

closes #659 
makes use of discussion on closed pr #673

---------

Signed-off-by: Noah Elzner <elzner@google.com>
Signed-off-by: Noah Elzner <78953604+enteraga6@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:BYOB An issue with the BYOB delegated workflows
Projects
None yet
Milestone
BYOB
2 participants
@laurentsimon @enteraga6