Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature][byob] Verification for sha1 provided by TRW for v1.0 #600

Closed
laurentsimon opened this issue May 18, 2023 · 3 comments · Fixed by #641
Closed

[feature][byob] Verification for sha1 provided by TRW for v1.0 #600

laurentsimon opened this issue May 18, 2023 · 3 comments · Fixed by #641
Assignees
@ianlewis
Labels
specs:v1.0
Milestone
BYOB

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented May 18, 2023 •
edited
Loading

verification counterpart for slsa-framework/slsa-github-generator#2137

Make sure to follow the comments in #599 and differentiate between generators and builders
@laurentsimon laurentsimon changed the title [feature][byob] Verification for sha1 for v1.0 [feature][byob] Verification for sha1 provided by TRW for v1.0 May 18, 2023
@laurentsimon laurentsimon added this to the BYOB milestone May 18, 2023
@laurentsimon
Copy link
Contributor Author

blocked on #604 and #605

@ianlewis ianlewis self-assigned this May 23, 2023
@ianlewis ianlewis mentioned this issue May 25, 2023
Closed
@laurentsimon laurentsimon mentioned this issue May 27, 2023
Closed
@ianlewis ianlewis mentioned this issue Jun 2, 2023
Merged
@ianlewis
Copy link
Member

ianlewis commented Jun 6, 2023

Blocked on slsa-framework/github-actions-buildtypes#4

@ianlewis ianlewis added the status:blocked This issue is currently blocked on something. label Jun 6, 2023
@ianlewis
Copy link
Member

We'll assume the source by normal means for now and worry about the official source designation once it's been decided on.

@ianlewis ianlewis removed the status:blocked This issue is currently blocked on something. label Jun 16, 2023
@ianlewis ianlewis mentioned this issue Jun 16, 2023
Merged
ianlewis pushed a commit that referenced this issue Jul 25, 2023
@laurentsimon
feat: Verification for when sha1 is specified in BYOB TRW (#641)
e7fc7a4 
Fixes #600

---------

Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianlewis ianlewis

Labels
specs:v1.0
Projects
None yet
Milestone
BYOB
2 participants
@ianlewis @laurentsimon