feat: Add npm builder workflow #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
asraa,
ianlewis and
joshuagl
as code owners
ianlewis
reviewed
Sep 21, 2022
ianlewis
reviewed
Sep 21, 2022
| set -euo pipefail | ||
|
|
||
| # npm ci <args> | ||
| ./"$BUILDER_BINARY" ci \ |
There was a problem hiding this comment.
I wonder if we can't combine the ci and build steps. especially if we will always be running npm ci
There was a problem hiding this comment.
One reason (maybe not a strong one) is if we want to turn on some OS-level hermeticity after downloading the dependencies in the future. It could arguably be done in the builder's code as well...
laurentsimon
force-pushed
the
feat/npmworkflow
branch
from
a112c83
to
1b1232a
Compare
laurentsimon
force-pushed
the
feat/npmworkflow
branch
from
d8dbf34
to
959ffab
Compare
|
friendly ping |
ianlewis
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new workflow
builder_node_slsa3.yml. It contains the structure to build upon for follow-up PRs that will create the node builder itself.