-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add directory input to Maven builder #2538
feat: Add directory input to Maven builder #2538
Conversation
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. You could do some verification on the path to make sure it's under the workspace, something like https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/secure-download-artifact/action.yml#L42-L48
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
@laurentsimon Could you have another look, please? |
TBF, I believe the chdir would happen in the "untrusted" build's job anyway. So I don't think this is super important (though necessary if it's used elsewhere). |
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz friendly ping to update this PR |
Signed-off-by: AdamKorcz <adam@adalogics.com>
Thanks for the ping! Resolved the comments. |
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Adds another
input
for the Maven builder to allow the user to specify the project directory. The current problem this solves is to make slsa-framework/example-package#253 work.This was suggested by @laurentsimon in slsa-framework/example-package#253 (comment)