Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e]: sign-attestations schedule #3002

Closed
github-actions bot opened this issue Nov 27, 2023 · 150 comments
Closed

[e2e]: sign-attestations schedule #3002

github-actions bot opened this issue Nov 27, 2023 · 150 comments
Labels
area:sign-attestations Issue with the sign-attestations action e2e e2e integration tests type:bug Something isn't working

Comments

@github-actions github-actions bot added area:sign-attestations Issue with the sign-attestations action e2e e2e integration tests type:bug Something isn't working labels Nov 27, 2023
ramonpetgrave64 added a commit that referenced this issue Apr 24, 2024
# Summary

Addresses
#3002

Fixes the .github/workflows/e2e.sign-attestations.schedule.yml workflow.
sigstore-js now has its cli tools in a separate package, to be installed
with `install -g @sigstore/cli`.

## Testing Process

Invoked the workflow from my personal fork

-
https://github.com/ramonpetgrave64/slsa-github-generator/actions/runs/8757196289/job/24035331070#step:6:11

```
Verification succeeded
Verification succeeded
```

We can't add this to a pre-submit, because it requires token permissions
that are not available to forks' PR runs.

## Checklist

- [x] Review the contributing [guidelines](./../CONTRIBUTING.md)
- [x] Add a reference to related issues in the PR description.
- [ ] Update documentation if applicable.
- [ ] Add unit tests if applicable.
- [ ] Add changes to the [CHANGELOG](./../CHANGELOG.md) if applicable.

---------

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sign-attestations Issue with the sign-attestations action e2e e2e integration tests type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants