Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-170 Update error logging in Upvs::SubmitMessageDraftJob #557

Merged
merged 1 commit into from
Feb 27, 2025
Merged

GO-170 Update error logging in Upvs::SubmitMessageDraftJob #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions app/jobs/govbox/submit_message_draft_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def perform(message_draft, bulk_submit: false, upvs_client: UpvsEnvironment.upvs
message_draft.submitted!
Govbox::SyncBoxJob.set(wait: 3.minutes).perform_later(box) unless bulk_submit
else
handle_submit_fail(message_draft, response_status, response_body.dig("message"))
handle_submit_fail(message_draft, response_status, response_body)
end
end

Expand All @@ -81,7 +81,7 @@ def build_objects(message_draft)
objects
end

def handle_submit_fail(message_draft, response_status, response_message)
def handle_submit_fail(message_draft, response_status, response_body)
# TODO notification
message_draft.add_cascading_tag(message_draft.tenant.submission_error_tag)

Expand All @@ -90,12 +90,16 @@ def handle_submit_fail(message_draft, response_status, response_message)
message_draft.metadata["status"] = "temporary_submit_fail"
message_draft.save

raise TemporarySubmissionError, "Message #{message_draft.uuid}: #{response_status}, #{response_message}"
raise TemporarySubmissionError, error_message(message_draft, response_status, response_body)
else
message_draft.metadata["status"] = "submit_fail"
message_draft.save

raise SubmissionError, "Message #{message_draft.uuid}: #{response_status}, #{response_message}"
raise SubmissionError, error_message(message_draft, response_status, response_body)
end
end

def error_message(message_draft, response_status, response_body)
"Box #{message_draft.box.id}, Message #{message_draft.uuid}: #{response_status}, #{response_body}"
end
end