Fixed text input on Android, fixed for older Android versions #7204

wuwbobo2021 · 2024-12-24T00:52:13Z

Fixes #7182 and part of #7203.

Note: #4973 may be closed by checking this version of Android build tools: #6695.

wuwbobo2021 · 2024-12-25T23:37:01Z

I've modified the build script of the android activity backend crate, #4920 can be closed. (I had been using the method provided in this issue)

ogoffart

Thanks a lot for the PR. I'll need to try it out.
This is great because I don't have much experience with older Android and you seem to know better than me.
Perhaps in order to make the review simpler and if it's not too much to ask, could you split the PR in 3 different PR:

The material changes
The Support for old android
The fix for the text input.

So that we can merge the changes independently and some may be easier than others.
Thanks!

ogoffart · 2024-12-26T17:15:30Z

internal/backends/android-activity/build.rs

+    // Try to locate javac and java
+    let javac_java = env_var("JAVA_HOME")
+        .map(|home| PathBuf::from(home).join("bin"))
+        .map(|bin| (bin.join("javac"), bin.join("java")));


I hope this also work on windows without the .exe

Yes, I have tested it, it works on Windows 10 indeed.

I did another test under a non-ASCII path with a space and it works too.

ogoffart · 2024-12-26T17:24:54Z

internal/compiler/widgets/material/styling.slint

@@ -29,13 +29,13 @@ export global Elevation {

 export global MaterialPalette {


Maybe the change to the material style can be extracted into a different PR?

ogoffart · 2024-12-26T17:31:45Z

internal/backends/android-activity/javahelper.rs


-    for (utf8_index, c) in in_str.char_indices() {
-        if utf16_counter >= utf16_index {
+    for (utf8_index, _) in in_str.char_indices() {


I think this could be implemented with in_str.char_indices().skip(char_index).0 or something like that.

But are you sure UTF-32 is the right encoding in Java? I was under the impression it was UTF-16

Sorry, I made a mistake. I recovered it according to your original code.

wuwbobo2021 · 2024-12-27T02:30:28Z

I have recovered the material style. Are my seperated commits clear enough?

wuwbobo2021 · 2024-12-27T03:16:46Z

I have failed to fix the last bug described in #7203 which is related to Unicode index handling, and will not make further modifications in my branch (and posts in the issue), unless it is really required to do something.

I am not really good at Android application development. Support for old Android versions is done by asking Copilot (which had omitted a few things before I found them by myself), checking the documentation, modifying the Java code by myself, then trying to compile the Java helper with android-23 (commenting out imports and if branches for higher versions temporarily), running it on Android 6.0.

PS: I will not use the Copilot anymore. My wrong modification of string index convertion is discovered by myself before your review.

wuwbobo2021 · 2024-12-28T05:54:15Z

Excuse me, the unsafe jni_get_string function added in javahelper.rs can be turned into a safe function according to jni-rs/jni-rs#557. Tell me to do so if it's required.

wuwbobo2021 · 2024-12-28T22:54:26Z

I did one more modification because I think it should be required to do this to preserve safety, in case of the Java code's behavior were to be changed in the future.

I apologize to you again for my wrong modification of string index convertion functions, which has been realized and recovered by myself (android.text.Selection depends on the CharSequence interface which uses the UTF-16 index, and I did a test to prove it). I posted it on the issue page before your review, but the correction was uploaded after your review, though.

Please tell me "splitting the PR is really required" instead of "could you split the PR in 2 different PR" to make me do so. Thank you!

wuwbobo2021 · 2024-12-28T23:01:52Z

internal/renderers/skia/textlayout.rs

Some bug existing elsewhere in the Skia module may be fixed in the future to eliminate this check.

wuwbobo2021 · 2024-12-28T23:05:04Z

internal/backends/android-activity/java/SlintAndroidJavaHelper.java

Modifications in get_clipboard() and set_clipboard() are needed to prevent them from crashing the application. Others fix support for old Android versions (6.0 to 9.0).

wuwbobo2021 · 2024-12-28T23:13:39Z

internal/backends/android-activity/java/SlintAndroidJavaHelper.java

Modifications in get_clipboard() and set_clipboard() are needed to prevent them from crashing the application. Others fix support for old Android versions (6.0 to 9.0).

wuwbobo2021 · 2024-12-28T23:23:32Z

internal/backends/android-activity/javahelper.rs

Reduced leaked class object reference in load_java_helper(app: &AndroidApp), which isn't supposed to be called repeatedly;

Added env.auto_local or env.delete_local_ref for other places where new JNI local references are created. This fixes possible crashing on Android versions older than Android 8.0, which don't allow keeping unlimited amount of JNI local references.

The latest forced pushing https://github.com/slint-ui/slint/compare/c0de25edad9b7d524123d061230a848cdcce594c..a02aeded5cdbc24e4fccd219614b2bd4a7f285f8 removes 2 lines of outdated "safety" comments.

wuwbobo2021

All files are checked again by myself.

ogoffart

Thanks a lot for fixing all that. This looks sensible to me.
I still want to test it before merging.
Sorry for being so slow to answer, but this is the holiday seasons and I'll have more time after new year.

ogoffart · 2024-12-30T09:16:46Z

internal/backends/android-activity/androidwindowadapter.rs

+                    // FIXME: I don't know why this is the case, but without this, the soft input
+                    // always prompt out on startup.


Suggested change

// FIXME: I don't know why this is the case, but without this, the soft input

// always prompt out on startup.

// Without this, the soft input always prompt out on startup.

Is it only on some version of android?
Is it because there is a text field with the focus on startup?

Oh sorry, I tested an application without any text box, without this modification, the virtual keyboard isn't shown on Android 11.0, but it's shown on Android 6.0 and 8.0. I haven't tested Android 9.0 and 10.0 yet.

ogoffart · 2025-01-03T10:18:57Z

I did test the PR locally and it seemed to work. Thanks for your contribution!

Fixes for older Android versions (6.0 to 9.0)

ba4b017

wuwbobo2021 changed the title ~~Fixed for older Android versions, fixed soft input prompting on startup, modified material style~~ Fixed text input on Android, fixed for older Android versions, modified material style Dec 25, 2024

ogoffart reviewed Dec 26, 2024

View reviewed changes

wuwbobo2021 added 3 commits December 27, 2024 10:18

Fix build script for Android (slint-ui#4920)

383bef9

Fix clipboard operations on Android

e27d0ca

Fix TextEdit crashing on Android (slint-ui#7203)

e12ecb5

wuwbobo2021 force-pushed the master branch from 6ce33b0 to e12ecb5 Compare December 27, 2024 02:29

wuwbobo2021 changed the title ~~Fixed text input on Android, fixed for older Android versions, modified material style~~ Fixed text input on Android, fixed for older Android versions Dec 27, 2024

wuwbobo2021 commented Dec 28, 2024

View reviewed changes

Remove unsafe calls added in 'Fixes for older Android versions'

a02aede

wuwbobo2021 force-pushed the master branch from c0de25e to a02aede Compare December 28, 2024 23:11

wuwbobo2021 commented Dec 28, 2024

View reviewed changes

ogoffart reviewed Dec 30, 2024

View reviewed changes

Update a comment in androidwindowadapter.rs

37ea1eb

wuwbobo2021 mentioned this pull request Jan 1, 2025

Text input bugs of the Android backend and the Skia renderer #7203

Open

ogoffart merged commit a60c3b3 into slint-ui:master Jan 3, 2025
37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed text input on Android, fixed for older Android versions #7204

Fixed text input on Android, fixed for older Android versions #7204

wuwbobo2021 commented Dec 24, 2024 •

edited

Loading

wuwbobo2021 commented Dec 25, 2024

ogoffart left a comment

ogoffart Dec 26, 2024

wuwbobo2021 Dec 27, 2024

wuwbobo2021 Dec 28, 2024

ogoffart Dec 26, 2024

ogoffart Dec 26, 2024

wuwbobo2021 Dec 27, 2024

wuwbobo2021 commented Dec 27, 2024

wuwbobo2021 commented Dec 27, 2024 •

edited

Loading

wuwbobo2021 commented Dec 28, 2024

wuwbobo2021 commented Dec 28, 2024 •

edited

Loading

wuwbobo2021 Dec 28, 2024

wuwbobo2021 Dec 28, 2024

wuwbobo2021 Dec 28, 2024

wuwbobo2021 Dec 28, 2024

wuwbobo2021 Dec 28, 2024 •

edited

Loading

wuwbobo2021 left a comment

ogoffart left a comment

ogoffart Dec 30, 2024

wuwbobo2021 Dec 30, 2024

ogoffart commented Jan 3, 2025

		@@ -29,13 +29,13 @@ export global Elevation {

		export global MaterialPalette {

		// FIXME: I don't know why this is the case, but without this, the soft input
		// always prompt out on startup.

	// FIXME: I don't know why this is the case, but without this, the soft input
	// always prompt out on startup.
	// Without this, the soft input always prompt out on startup.

Fixed text input on Android, fixed for older Android versions #7204

Fixed text input on Android, fixed for older Android versions #7204

Conversation

wuwbobo2021 commented Dec 24, 2024 • edited Loading

wuwbobo2021 commented Dec 25, 2024

ogoffart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wuwbobo2021 commented Dec 27, 2024

wuwbobo2021 commented Dec 27, 2024 • edited Loading

wuwbobo2021 commented Dec 28, 2024

wuwbobo2021 commented Dec 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wuwbobo2021 Dec 28, 2024 • edited Loading

Choose a reason for hiding this comment

wuwbobo2021 left a comment

Choose a reason for hiding this comment

ogoffart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogoffart commented Jan 3, 2025

wuwbobo2021 commented Dec 24, 2024 •

edited

Loading

wuwbobo2021 commented Dec 27, 2024 •

edited

Loading

wuwbobo2021 commented Dec 28, 2024 •

edited

Loading

wuwbobo2021 Dec 28, 2024 •

edited

Loading