-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std-widgets: added LayoutSettings global #6711
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think it make sense to expose the layout margin and padding through a global.
I don't think the text-cursor-width make sense to be exposed though. This is also not related to layout.
As for the name LayoutSettings
, this means it is specific to layout, but could it be used for other settings in the future?
Also are these really "Settings"? Settings implies that you can change them. Maybe they are StyleParameters
or StyleProperties
?
@ogoffart the For the name I'm open for an alternative. Suggestion // Brushes
global Palette { ... }
// Font settings e.g. TextStyles.header.font-size, TextStyles.header.font-weight
global TextStyles { ... }
global LayoutParameters { ... } What you you think? |
Fixes #6698