Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: ensure that CI fails if there is a formatting error #5407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: ensure that CI fails if there is a formatting error #5407

wants to merge 1 commit into from

Conversation

ogoffart
Copy link
Member

reviewdog is not always failling

@ogoffart
Copy link
Member Author

There are rust formatting problems in master, and they were not catched by CI

@ogoffart
Copy link
Member Author

That doesn't work.
It looks like from the log reviewdog is somehow dropping the stash and thereby removing all the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronical tronical tronical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogoffart @tronical