Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add android example - calculator #3936

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add android example - calculator #3936

wants to merge 2 commits into from

Conversation

1595901624
Copy link

This is a Android calculator example in Slint 1.3.0

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@FloVanGH
Copy link
Member

Hi, thank you very much for the PR. @ogoffart is the best to review this PR, because he is working on the Android port. He will be back next week.

@ogoffart
Copy link
Member

Thank you for your contribution, and my apologies for the delayed response.

The calculator example is a great addition, but before we merge it, there are a few issues to address:

  • The CI is flagging a license header issue. We can either update the files with the expected copyright header or modify the CI script to allow different names in the copyright line, which is something we've been considering

  • Hardcoded Button Height: I noticed the button height is hardcoded. Consider using a percentage or rem value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1595901624 @CLAassistant @FloVanGH @ogoffart