vscode: add "wrap in element" code action #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Goffart <olivier@woboq.com>
|
A cool feature, indeed. Thanks for implementing it. |
hunger
reviewed
Sep 7, 2023
| @@ -621,7 +621,7 @@ fn set_binding_on_known_property( | |||
|
|
|||
| // Find the indentation of the element itself as well as the indentation of properties inside the | |||
| // element. Returns the element indent followed by the block indent | |||
| fn find_element_indent(element: &ElementRc) -> Option<String> { | |||
| pub fn find_element_indent(element: &ElementRc) -> Option<String> { | |||
There was a problem hiding this comment.
This should probably get moved to a more discoverable place, now that it got promoted to a generic utility function.
That can be a separate patch and does not need to be done in here.
There was a problem hiding this comment.
Sounds good. The comment looks outdated too. I can follow up with a separate PR.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little productivity booster for editing .slint files in VS Code:
vscode-wrap-in-element.mov
Notice that LSP code actions and workspace edits do not yet natively support snippets or allow specifying the cursor position (microsoft/language-server-protocol#724), which is necessary for pre-selecting "element" for conveniently typing in the desired type name. This limitation is worked around by registering an experimental "snippet text edit" capability for the client, guarding the snippet code action with a capability check on the server side, and finally, detecting and inserting the snippet on the client side (inspired by rust-analyzer and Dart-Code).