Revert 1606 to allow routing of /index.php/foo again #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #1606 changed the way that the Uri's baseUrl was detected in order to fix #1590. However, this change meant that routing of URLs of the form /foo/index.php/bar/baz no longer worked. This commit reverts #1606 so that routing works again as the stripping off of the script name when using rewriting could be done at the web server configuration level, or via a route the redirects to the one without the script name in it.
codeguy
added a commit
that referenced
this pull request
Dec 4, 2015
Revert 1606 to allow routing of /index.php/foo again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1606 changed the way that the Uri's baseUrl was detected in order to fix #1590. However, this change meant that routing of URLs of the form
/foo/index.php/bar/bazno longer worked.This commit reverts #1606 so that routing works again as the stripping off of the script name when using rewriting could be done at the web server configuration level, or via a route the redirects to the one without the script name in it.
Fixes #1639.