Bind container to route callable #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with middleware, bind the container to the route callable too. In order to avoid breaking too many current apps, also implement __get() and __isset() on Container, though this won't help those who have been using $this->getContainer().
codeguy
added a commit
that referenced
this pull request
Nov 28, 2015
Bind container to route callable
rotexdegba
added a commit
to rotexsoft/slim-skeleton-mvc-app
that referenced
this pull request
Nov 30, 2015
… now being bound to the Slim App's container instead of the Slim App itself inside route callables slimphp/Slim#1631 .
rotexdegba
added a commit
to rotexsoft/slim-skeleton-mvc-tools
that referenced
this pull request
Nov 30, 2015
… now being bound to the Slim App's container instead of the Slim App itself inside route callables slimphp/Slim#1631 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with middleware, bind the container to the route callable too.
In order to avoid breaking too many current apps, also implement __get() and __isset() on Container, though this won't help those who have been using $this->getContainer().
Fixes #1602