Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change visibility on the add method to protected #1550

Merged
merged 2 commits into from
Oct 29, 2015
Merged

Change visibility on the add method to protected #1550

merged 2 commits into from
Oct 29, 2015

Conversation

silentworks
Copy link
Member

In relation to #1516

@silentworks silentworks self-assigned this Oct 22, 2015
@silentworks silentworks added this to the 3.0.0 RC2 milestone Oct 22, 2015
@silentworks silentworks removed their assignment Oct 22, 2015
@akrabat
Copy link
Member

akrabat commented Oct 22, 2015

Would it make more sense to rename MiddlewareTrait's add to addMiddleware ?

@silentworks
Copy link
Member Author

Yes, since we seem to be just aliasing it as that anyway.

@akrabat
Copy link
Member

akrabat commented Oct 22, 2015

ok - will wait for you to make that change before merging.

@akrabat akrabat merged commit 45bbb8f into slimphp:3.x Oct 29, 2015
@akrabat akrabat mentioned this pull request Oct 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Slim 3
Projects
None yet
Milestone
3.0.0 RC2
Development

Successfully merging this pull request may close these issues.
2 participants
@silentworks @akrabat