Pass settings to Pimple

[akrabat]

This allows a user to configure the container via settings.

Fixes #1407

[geggleto]

You are a rockstar :) 👍

[codeguy]

👍

[silentworks]

Is it me or would we be passing settings to Pimple then replacing it right after on line 71?

[geggleto]

Yeah it does appear that it will get passed in twice. but only the ['settings'] part of the user provided array.

[akrabat]

It's laziness on my part to avoid changing the default settings merging. Will see if I can tidy it up.

[silentworks]

Nah leave it, its probably quicker to replace it twice than to pop it off the array. Will merge, you can cleanup later if you wish.

[ConstantineYurevich]

Unfortunately, this PR doesn't have backward compatibility. Before I was able to "override" container values before $app->run().

Before I was able to do the following in unit tests:

$app = new \Slim\App();

Configurator::configureApp($app); //seudo-code

$c = $app->getContainer();
$c['environment'] = $c->factory(function ($c) {
....
});
$c['request'] = $c->factory(function ($c) {
....
});

Now it is not possible, getting following error:

RuntimeException : Cannot override frozen service "environment".

And main problem is that now you freeze almost all container variables during router initialisation:

Before it was (worked perfectly):

 $this['router'] = function ($c) {
     return new Router();
};

Not it is:

if (!isset($this['router'])) {
            $this['router'] = function ($c) {
                $router = new Router();

                $uri = $c['request']->getUri();

                if (is_callable([$uri, 'getBasePath'])) {
                    $router->setBasePath($uri->getBasePath());
                }

                return $router;
            };
}

As you can see, now you access $c['request'], which automatically freezes almost all essential components in container.

[ConstantineYurevich]

Main idea is that essential container components, such as environment, request and response should not be frozen before app run.

Use case:

1. I want to configure my application (including all routes, acl, domain services, etc)
2. Save it to static property or to cache.
3. Override container's environment, request and response with factories.
4. Run many tests against the same instance of application.

[akrabat]

@yurevichcv Please open a new issue as it may be related to #1443 rather than this PR.

[silentworks]

This has been the case before this change was made, you probably just didn't notice it before. Services are frozen from the minute they get called, this is how Pimple works.

[ConstantineYurevich]

Yes, sorry, you are right. This PR caused the problem - #1443

[ConstantineYurevich]

@silentworks Yes, I know how Pimple works. But environment, request and response should not be frozen before app run. This limits flexibility in testing. request is the most essential entry point, and it should be called only once, further it should just be "travelling" between middleware and routes.

The same issue was in Twig-View extension, where I also sumbmitted my PR against request freezing during initialization phase - slimphp/Twig-View#30

[geggleto]

@yurevichcv you are free to overwrite the defaults at any time during execution by simply overwriting the default container instance like this.

unset($container['environment']);
$container['environment'] = new Environment();