Add foundHandler that implements a new InvocationStrategyInterface #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow a foundHandler in the container to describe what parameters are injected into the callable defined for a found route.
codeguy
added a commit
that referenced
this pull request
Jul 9, 2015
Add foundHandler that implements a new InvocationStrategyInterface
| * | ||
| * @return mixed | ||
| */ | ||
| public function invoke(ContainerInterface $container, array $route, ServerRequestInterface $request, ResponseInterface $response); |
There was a problem hiding this comment.
Why not the magic __invoke() method? This custom invoke() might be confusing.
And why is the container a parameter here? If it is needed for a strategy it can be inserted in the constructor.
There was a problem hiding this comment.
Both suggestions make good sense to me. I'll create another PR unless anyone else sees a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a foundHandler in the container to describe what parameters are injected into the callable defined for a found route.