Update dependencies #209
Merged
Update dependencies #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With composer.lock in the project CI will build against a known set of dependencies which will make it easier for testing as we'll know if a failed test is related to our changes. At the moment, the failure could be because of a dependency's changes.
Nyhom::Psr7 now normalises leading slashes in getPath() if there is an authority, so we need to not set an authority any more.
|
@akrabat I'm not sure I understand the coveralls bit you changed, it seems to not be reporting status with that change now. Am I mistaken? Otherwise looks good to me. |
You're not mistaken. Clearly not quite there yet! |
akrabat
force-pushed
the
update-deps
branch
2 times, most recently
from
f2dfd47 to
ebf4728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies and commit composer.lock. With composer.lock in the project CI will build against a known set of
dependencies which will make it easier for testing as we'll know if a failed test is related to our changes. At the moment, the failure could be because of a dependency's changes.