Remove token on validation #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When persistent mode is off, then the token should be removed from the storage when it has been validated. This test did not do this, but does do now.
When the token is successfully validated and we are not in persistent mode, then we need to remove the token. This is a separate operation to handling failure. The side-effect of the previous code is that is allowed a replay attack where the same token could be used multiple times even when persisent mode was disabled. Thanks to Xhelal Likaj (https://github.com/xhlika) for the report.
akrabat
force-pushed
the
remove-token-on-validation
branch
from
3061678 to
009a4bd
Compare
l0gicgate
requested changes
Jan 4, 2021
This is required for PHP7.3+ as our phpunit.xml.dist automatically creates coverage.
akrabat
force-pushed
the
remove-token-on-validation
branch
2 times, most recently
from
a98443c to
e2d11fb
Compare
akrabat
force-pushed
the
remove-token-on-validation
branch
from
e2d11fb to
9fe81ac
Compare
l0gicgate
requested changes
Jan 6, 2021
l0gicgate
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure token is removed in persisent mode on validation
When the token is successfully validated and we are not in persistent mode, then we need to remove the token. This is a separate operation to handling failure.
The side-effect of the previous code is that is allowed a replay attack where the same token could be used multiple times even when persisent mode was disabled.
Thanks to @xhlika for the report.