Incompatible with phpstan/phpdoc-parser >= 1.6

[martijnc]

phpstan/phpdoc-parser@1.6.0 introduced PHPStan\PhpDocParser\Ast\PhpDoc\TypelessParamTagValueNode in phpstan/phpdoc-parser@9d45205 which it returns instead of PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode for docblock @param definitions without a type.

Slevomat typehints ParamTagValueNode in ParameterAnnotation::__construct(), but as of phpdoc-parser@1.6.0 this can also be TypelessParamTagValueNode resulting in the following error when PHPCS encounters a docblock with a typeless @param.

Fatal error: Uncaught TypeError: SlevomatCodingStandard\Helpers\Annotation\ParameterAnnotation::__construct(): Argument #5 ($contentNode) must be of type ?PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode, PHPStan\PhpDocParser\Ast\PhpDoc\TypelessParamTagValueNode given, called in /Volumes/Projects/mortar/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/AnnotationHelper.php on line 357 and defined in /Volumes/Projects/mortar/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/Annotation/ParameterAnnotation.php:31

[esserj]

example annotation
@param $someTypelessParam

[akalongman]

As a workeround I added "phpstan/phpdoc-parser": "1.5.*" in a composer.json

[kukulich]

Implemented in 55e5dc5

[Ilyes512]

Awesome that it was fixed so quickly! Can we have a new tag/release @kukulich? Thanks!

[kukulich]

@Ilyes512 There's sponsor button on the top of this page.

[Ilyes512]

Whoa... that does sound a little passive aggressive, but I will definitly keep you in mind in future :). Your work definitly deserve compensation!

[kukulich]

It's easy. I work on this mostly in my free time. So if you ask for release, you can motivate me to do it :) Or just wait :)

[ViktorCollin]

First of all I want to thank you for your good work of this!

Im curious if it would be possible to patch this even in the 7.2 branch and release a fix version for it or is that not part of the plan?

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.