Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow mutliple listeners & auth #13

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Conversation

emoruzzi
Copy link
Contributor

No description provided.

@sleighzy
Copy link
Owner

Hi @emoruzzi . Thanks for the contribution, much appreciated. Sorry about the delay on this, I'm currently on vacation. Will run through this in greater detail when I return and get back to with any feedback or merge. Thanks.

Copy link
Owner

@sleighzy sleighzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, couple of minor changes.

defaults/main.yaml Outdated Show resolved Hide resolved
templates/server.properties.j2 Show resolved Hide resolved
defaults/main.yaml Outdated Show resolved Hide resolved
@emoruzzi emoruzzi force-pushed the new_listeners branch 2 times, most recently from 6a116c1 to ee87e73 Compare July 20, 2021 18:22
Copy link
Owner

@sleighzy sleighzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the update to kafka_listeners and then should be good to go.

templates/server.properties.j2 Outdated Show resolved Hide resolved
@sleighzy
Copy link
Owner

sleighzy commented Aug 5, 2021

Hi @emoruzzi . Are you able to make the outstanding change to have this PR completed? Would be good to see this as part of the role so I am appreciating your efforts.

@emoruzzi
Copy link
Contributor Author

emoruzzi commented Aug 5, 2021

Fixed the issues - sorry didn't get the last email. Thanks for checking back in.

@sleighzy sleighzy merged commit 9a3d2c3 into sleighzy:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants