Add support for disabling certificate validation when downloading the…

… Kafka package
sleighzy · Jul 8, 2022 · e15004f · e15004f
1 parent d9537b6
commit e15004f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -45,6 +45,7 @@ See <https://github.com/ansible/ansible/issues/71528> for more information.
 | Variable                                       | Default                          |
 | ---------------------------------------------- | -------------------------------- |
 | kafka_download_base_url                        | <https://dlcdn.apache.org/kafka> |
+| kafka_download_validate_certs                  | yes                              |
 | kafka_version                                  | 3.2.0                            |
 | kafka_scala_version                            | 2.13                             |
 | kafka_create_user_group                        | true                             |

diff --git a/defaults/main/001-kafka.yml b/defaults/main/001-kafka.yml
@@ -2,6 +2,7 @@
 # The Apache Kafka version to be downloaded and installed
 # kafka_download_base_url should be set to https://archive.apache.org/dist/kafka/ for older versions than the current
 kafka_download_base_url: https://dlcdn.apache.org/kafka
+kafka_download_validate_certs: yes
 kafka_version: 3.2.0
 kafka_scala_version: 2.13
 

diff --git a/molecule/default/molecule.yml b/molecule/default/molecule.yml
@@ -83,6 +83,7 @@ provisioner:
         zookeeper_id: 2
         kafka_broker_id: 1
         kafka_listener_hostname: server-2
+        kafka_download_validate_certs: no
       server-3:
         zookeeper_id: 3
         kafka_broker_id: 2

diff --git a/tasks/main.yaml b/tasks/main.yaml
@@ -1,6 +1,6 @@
 ---
 - name: Load OS-specific variables
-  include_vars: "{{ item }}"
+  include_vars: '{{ item }}'
   with_first_found:
     - ../vars/{{ ansible_os_family }}.yml
     - ../vars/{{ ansible_distribution_release }}.yml
@@ -35,8 +35,9 @@
 
 - name: Download Apache Kafka
   get_url:
-    url: "{{ kafka_download_base_url }}/{{ kafka_version }}/kafka_{{ kafka_scala_version }}-{{ kafka_version }}.tgz"
+    url: '{{ kafka_download_base_url }}/{{ kafka_version }}/kafka_{{ kafka_scala_version }}-{{ kafka_version }}.tgz'
     dest: /tmp
+    validate_certs: '{{ kafka_download_validate_certs }}'
   when: not dir.stat.exists
   tags:
     - kafka_download
@@ -262,7 +263,7 @@
 - name: Template kafka systemd service
   template:
     src: kafka.service.j2
-    dest: "{{ kafka_unit_path }}"
+    dest: '{{ kafka_unit_path }}'
     group: '{{ kafka_group }}'
     owner: '{{ kafka_user }}'
     mode: 0644