Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom words blocked #190

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Conversation

gpedro
Copy link
Contributor

@gpedro gpedro commented Mar 23, 2022

allow easy blocking: prefix, name, and word in character name

@slawkens slawkens changed the base branch from master to develop May 31, 2022 10:29
@slawkens slawkens changed the base branch from develop to master May 31, 2022 10:29
@slawkens
Copy link
Owner

slawkens commented May 31, 2022

Hello, I find that latest commit wasn't good removing that from config.

What do you say if I revert it?

@gpedro
Copy link
Contributor Author

gpedro commented Jun 4, 2022

what do u mean?

@slawkens
Copy link
Owner

slawkens commented Jun 4, 2022

I think it was good to have it configurable in config.php

That part with God, GM etc.

@gpedro
Copy link
Contributor Author

gpedro commented Jun 5, 2022

i keep these keywords in the code to avoid problems when users upgrade the version and forget about adding this config

@slawkens
Copy link
Owner

Thanks one more time.

@slawkens slawkens merged commit dd3d6b3 into slawkens:master Jul 30, 2022
@gpedro gpedro deleted the feat/custom-name-blocked branch November 22, 2022 23:36
slawkens pushed a commit that referenced this pull request Jul 22, 2023
* Update config.php

* Update validator.php

* Update config.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants