Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guilds! #36

Closed
MxSoft opened this issue Jan 7, 2018 · 6 comments
Closed

Guilds! #36

MxSoft opened this issue Jan 7, 2018 · 6 comments

Comments

@MxSoft
Copy link

MxSoft commented Jan 7, 2018 •
edited
Loading

Hello! In my player i have custom vocations and when for example someone leaves a guild or be named guild leader its vocation change to 0, also in admin when i want to save a change in a player i cant set custom vocation, it says that Vocation id cannot be longer than 1 digits.
slawkens added a commit that referenced this issue Jan 7, 2018
@slawkens
* fixed saving custom vocations in admin panel (#36)
7ab1c11
slawkens added a commit that referenced this issue Jan 7, 2018
@slawkens
* fixed saving custom vocations in admin panel (#36)
bcb0fee
@slawkens
Copy link
Owner

slawkens commented Jan 7, 2018

Does you players table contains promotion column?

Also, what distribution do you use?

And last question: is this player promoted when leaving guild?

@MxSoft
Copy link
Author

MxSoft commented Jan 7, 2018

No, it dosnt have promotion, it works as player_storage
0.4
Yes

@slawkens
Copy link
Owner

slawkens commented Jan 7, 2018 •
edited
Loading

Are you sure there's no players.promotion column in your database?

0.4 has such a column.

Its important for me to fix this.

@MxSoft
Copy link
Author

MxSoft commented Jan 7, 2018

Sorry my bad, yes i have

slawkens added a commit that referenced this issue Jan 8, 2018
@slawkens
* important fix for servers with promotion column (#36)
4102b44 
* caused player.vocation to be resetted when saving player, for example:
on change name, accept invite to guild, leave guild
* fixed empty success message on leave guild
* (internal) using $player->getVocationName() where possible instead of
older method
* fixed some warning in guild show
@slawkens
Copy link
Owner

slawkens commented Jan 8, 2018 •
edited
Loading

So, I've (hopefully) fixed it in this commit: bcf0541

Let me know if its working for you now.

Its enough when you update OTS_Player.php, rest is optional, or you can update your whole AAC (recommended).

Download the full version here (latest 0.7 to be released soon): https://github.com/slawkens/myaac/archive/0.7.zip

@MxSoft
Copy link
Author

MxSoft commented Jan 8, 2018

Fixed i think, i'll post if players report me errors thanx

@MxSoft MxSoft closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MxSoft @slawkens