Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add pre-commit as dependency #85

Merged
merged 3 commits into from
Apr 28, 2023
Merged

chore: Add pre-commit as dependency #85

merged 3 commits into from
Apr 28, 2023

Conversation

centenor
Copy link
Contributor

Fixes - #80

Resolution

  • Move pre-commit to being a required dependency. This should force the pip installation to pull that package down
  • Updating the homebrew formula creation script to filter out packages that are needed for pip but not the homebrew formula
  • Updating lock file to reflect pre-commit being moved to a dependency

@centenor centenor self-assigned this Apr 28, 2023
@centenor centenor linked an issue Apr 28, 2023 that may be closed by this pull request
secureli init fails with No such file or directory: 'pre-commit' error #80
Closed
@centenor centenor merged commit 41bcd3c into main Apr 28, 2023
@centenor centenor deleted the secureli-80 branch April 28, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbates sbates sbates approved these changes

@tristanl-slalom tristanl-slalom tristanl-slalom approved these changes

Assignees

@centenor centenor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

secureli init fails with No such file or directory: 'pre-commit' error
3 participants
@centenor @tristanl-slalom @sbates