-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slack-19.0
: support consul topo stale reads
#559
base: slack-19.0
Are you sure you want to change the base?
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but some CI failed. I triggered a re-run to see if that helps
@ejortegau the query serving downgrade tests on v19 are known-broken and currently not required CI For context, we've confirmed we shouldn't be impacted by the handful of failures in those CIs but we still need to modify the pipeline to understand this |
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Description
This PR allows Vitess components to use stale reads from consul. This is enabled with the flag
--topo_allow_stale_reads
, which is defaultfalse
and should be considered experimental*api.QueryOptions
:This flag allow us to distribute topo
.Get(...)
and.List(...)
load to consul replicas. Also it limits the impact of electionsIt may be safe in use cases like
txthrottler
if stale reads have no impact to any othervttablet
operations. It may be safe to use invtorc
alsoRelated Issue(s)
Checklist
Deployment Notes