Use setEnableByDefault instead for M2ApiDetector #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #80. Somewhat misleading from the lint API to say that severity isn't valid since it's one of the listed ones, but this better accomplishes the initial goal. One thing I'm not sure about is how to enable in `lint.xml` with this, and sort of assuming it's by just listing the issue in it with a severity.
chrisbanes
approved these changes
Mar 8, 2023
|
Tested the snapshot in catchup and looks like I was right about lint.xml but wrong about gradle. Severity is needed in lint.xml, even if it seems redundant. Same in Gradle, otherwise it's (weirdly) just a warning. Will update the doc with the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80. Somewhat misleading from the lint API to say that severity isn't valid since it's one of the listed ones, but this better accomplishes the initial goal. One thing I'm not sure about is how to enable in
lint.xmlwith this, and sort of assuming it's by just listing the issue in it with a severity.