Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ViewModelInjectionDetector to support tangleViewModel #46

Closed
wants to merge 2 commits into from
Closed

Update ViewModelInjectionDetector to support tangleViewModel #46

wants to merge 2 commits into from

Conversation

WhosNickDoglio
Copy link
Contributor

Adds support for Tangle to the ViewModelInjectionDetector

ZacSweers
ZacSweers reviewed Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, rather than adding to these would you be up for adding a lint option for users to define their own?

@chrisbanes
Copy link
Collaborator

We could even just generalize this to fun *ViewModel(). It's relying on convention, but it's good enough imo.

@WhosNickDoglio
Copy link
Contributor Author

Hmm, rather than adding to these would you be up for adding a lint option for users to define their own?

Great idea, I'll close this and start working on that.

@WhosNickDoglio WhosNickDoglio deleted the ndoglio-tangle-viewmodelinjection branch February 10, 2023 14:27
@WhosNickDoglio WhosNickDoglio mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WhosNickDoglio @chrisbanes @ZacSweers