Simplify filtering allowed and known ViewModel factory functions

slackhq · Feb 15, 2023 · 9419761 · 9419761
1 parent 2febb3f
commit 9419761
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/compose-lint-checks/src/main/java/slack/lint/compose/ViewModelInjectionDetector.kt b/compose-lint-checks/src/main/java/slack/lint/compose/ViewModelInjectionDetector.kt
@@ -72,8 +72,8 @@ constructor(private val allowedNames: StringSetLintOption = StringSetLintOption(
         property
           .findDirectChildrenByClass<KtCallExpression>()
           .filter {
-            KnownViewModelFactories.contains(it.calleeExpression?.text) ||
-              allowedNames.value.contains(it.calleeExpression?.text)
+            val allFactoryNames = KnownViewModelFactories + allowedNames.value
+            it.calleeExpression?.text in allFactoryNames
           }
           .map { property to it.calleeExpression!!.text }
       }