New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] 404 errors for video demo and css files #1951

Merged

ZacSweers merged 1 commit into slackhq:main from hossain-khan:hk/fix-404-errors

Feb 14, 2025

Contributor

hossain-khan commented Feb 14, 2025 •

edited

Loading

Summary

Some video URLs were broken because of how GitHub pages base URL uses the project name circuit.

Currently used: https://slackhq.github.io/videos/shared-elements-tutorial-step-5.mp4
Correct Path: https://slackhq.github.io/circuit/videos/shared-elements-tutorial-step-5.mp4

I used relative path instead to keep it simple and align with other usages.

📖 Affected page: https://slackhq.github.io/circuit/shared-elements-tutorial/

Fixes

Screenshot 2025-02-14 at 9 02 26 AM


          [FIXED] 404 errors for video demo and css files

331545f

salesforce-cla bot added the cla:signed label

ZacSweers approved these changes

View reviewed changes

Collaborator

ZacSweers left a comment

Thanks!

ZacSweers added this pull request to the merge queue

Merged via the queue into slackhq:main with commit 69270fd

5 checks passed

hossain-khan deleted the hk/fix-404-errors branch

February 14, 2025 15:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels