Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about only creating a presenter for supported screen types #1681

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add note about only creating a presenter for supported screen types #1681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,9 @@ class DetailPresenter(...) : Presenter<DetailScreen.State> {
}
```

Here we have access to the screen and dynamically create the presenter we need. It can then pass the screen on to the presenter.
Here we have access to the screen and dynamically create the presenter we need. It can then pass the screen on to the presenter.

Note: Circuit assumes that the `create` method will only return presenter instances for screen types it supports. If the screen type isn't supported, it's important to return `null` instead.

We can then wire these detail components to our `Circuit` instance too.

Expand Down
Loading