Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support secondary constructors for injection #1574

Merged
merged 3 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,8 @@ private class CircuitSymbolProcessor(
return null
}
} else {
creatorOrConstructor = declaration.primaryConstructor
creatorOrConstructor =
declaration.findConstructorAnnotatedWith(INJECT) ?: declaration.primaryConstructor
targetClass = declaration
}
val useProvider =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,60 @@ class CircuitSymbolProcessorTest {
)
}

@Test
fun uiClass_simpleInjection_secondaryConstructor() {
assertGeneratedFile(
sourceFile =
kotlin(
"TestUi.kt",
"""
package test

import com.slack.circuit.codegen.annotations.CircuitInject
import com.slack.circuit.runtime.ui.Ui
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import javax.inject.Inject

@CircuitInject(FavoritesScreen::class, AppScope::class)
class Favorites(val value: String) : Ui<FavoritesScreen.State> {

@Inject constructor() : this("injected")

@Composable
override fun Content(state: FavoritesScreen.State, modifier: Modifier) {

}
}
"""
.trimIndent(),
),
generatedFilePath = "test/FavoritesFactory.kt",
expectedContent =
"""
package test

import com.slack.circuit.runtime.CircuitContext
import com.slack.circuit.runtime.screen.Screen
import com.slack.circuit.runtime.ui.Ui
import com.squareup.anvil.annotations.ContributesMultibinding
import javax.inject.Inject
import javax.inject.Provider

@ContributesMultibinding(AppScope::class)
public class FavoritesFactory @Inject constructor(
private val provider: Provider<Favorites>,
) : Ui.Factory {
override fun create(screen: Screen, context: CircuitContext): Ui<*>? = when (screen) {
is FavoritesScreen -> provider.get()
else -> null
}
}
"""
.trimIndent(),
)
}

@Test
fun uiClass_assistedInjection() {
assertGeneratedFile(
Expand Down