Lock websocket-client version: temp fix for #385 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
shaydewael
approved these changes
Feb 28, 2019
1 task
9 tasks
ericswpark
added a commit
to ericswpark/python_transporter
that referenced
this pull request
Mar 29, 2019
The websocket connection drops because of inactivity. When it does, the slackclient library does not automatically attempt to reconnect without explicitly being told to do so. When we try to send a message while the socket is closed, we get an error and the script crashes. Pages related to this issue: slackapi/python-slack-sdk#118 https://slack.dev/python-slackclient/real_time_messaging.html#rtm-start-vs-rtm-connect Possible auto-ping solution required: https://github.com/TheKevJames/jarvis/blob/master/bot/jarvis/core/async.py#L39-L49 ----------------------------- Turns out, the websocket-client library has a fault with 0.55.0. Downgrading to 0.54.0 *should* fix the issue, but I already have 0.54.0 on my local machine, so that's not the problem. Issues: slackapi/python-slack-sdk#385 slackapi/python-slack-sdk#127 slackapi/python-slack-sdk#387
vivekkothari
pushed a commit
to vivekkothari/python-slackclient
that referenced
this pull request
Apr 12, 2019
lavabyrd
pushed a commit
that referenced
this pull request
Apr 25, 2019
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a temporary fix to resolve issues with the most recent
websocket-client0.55.0 release.Related Issues:
#385
#386
Requirements (place an
xin each[ ])