Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channels param to files.upload v2 method #1641

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 28, 2025

Summary

This pull request adds the newly added "channels" parameter to files.upload v2 method and its underlying API endpoint
See also: slackapi/java-slack-sdk#1427

Testing

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Jan 28, 2025
@seratch seratch added this to the 3.34.1 milestone Jan 28, 2025
@seratch seratch self-assigned this Jan 28, 2025
@seratch seratch force-pushed the channels-files-upload-v2 branch from bd9da9b to 9c3ba46 Compare January 28, 2025 08:26
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.36%. Comparing base (c77b863) to head (9c3ba46).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
slack_sdk/web/async_client.py 33.33% 2 Missing ⚠️
slack_sdk/web/client.py 33.33% 2 Missing ⚠️
slack_sdk/web/legacy_client.py 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   85.19%   85.36%   +0.17%     
==========================================
  Files         113      113              
  Lines       12823    12802      -21     
==========================================
+ Hits        10924    10928       +4     
+ Misses       1899     1874      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit ef3975b into slackapi:main Feb 3, 2025
12 of 13 checks passed
@seratch seratch deleted the channels-files-upload-v2 branch February 3, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants