Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov/codecov-action@v3 to upload code coverage #1376

Merged
merged 5 commits into from
May 27, 2023

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented May 26, 2023

Summary

This PR builds upon the changes in #1375 and replaces the codecov-uploader with the codecov-action. All in the hope of having coverage stats report successfully.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@zimeg zimeg added the tests M-T: Testing work only label May 26, 2023
@zimeg zimeg added this to the 3.21.4 milestone May 26, 2023
@zimeg zimeg requested a review from seratch May 26, 2023 23:05
@zimeg zimeg self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1376 (96c426a) into main (027a287) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         111      111           
  Lines       11582    11582           
=======================================
  Hits         9910     9910           
  Misses       1672     1672           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. The current way still works while it can be unstable due to codecov server-side issues. However, the way proposed here is a better one (our other repos do the same already). LGTM

@seratch seratch merged commit b65d3fc into slackapi:main May 27, 2023
@seratch seratch modified the milestones: 3.21.4, 3.22.0 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants