Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cursor based pagination to team.accessLogs #1368

Merged
merged 1 commit into from
May 17, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented May 17, 2023

Summary

This pull request adds a new feature to team.accessLogs API method. See https://api.slack.com/changelog for details.

See also: slackapi/java-slack-sdk#1160

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels May 17, 2023
@seratch seratch added this to the 3.22.0 milestone May 17, 2023
@seratch seratch self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #1368 (2b0bb2d) into main (7eec685) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2b0bb2d differs from pull request most recent head 1818742. Consider uploading reports for the commit 1818742 to get more accurate results

@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
- Coverage   85.58%   85.57%   -0.01%     
==========================================
  Files         111      111              
  Lines       11559    11559              
==========================================
- Hits         9893     9892       -1     
- Misses       1666     1667       +1     
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 82.33% <ø> (ø)
slack_sdk/web/client.py 83.59% <ø> (ø)
slack_sdk/web/legacy_client.py 83.33% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit dfc6b79 into slackapi:main May 17, 2023
@seratch seratch deleted the cursor-pagination-team-accessLogs branch May 17, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant