Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rtm.connect method over rtm.start to get websocket URL. #190

Closed
4 of 9 tasks
aoberoi opened this issue Jun 26, 2017 · 0 comments
Closed
4 of 9 tasks

Use rtm.connect method over rtm.start to get websocket URL. #190

aoberoi opened this issue Jun 26, 2017 · 0 comments

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Jun 26, 2017

Description

On very large Slack teams, the rtm.start payload can be too large to deliver before a timeout (server timeouts would return response 500, but also the websocket URL itself is short-lived so the timeout could be from the time it takes for the client to read the response).

The Slack platform has a new method called rtm.connect which is much smaller and faster to load. It also would provide the websocket URL.

I think this can be implemented as a swap of one for the other because the rtm.start data is not being returned to the user anyway (see #181), so that means there's no breaking API change by not having all the same data. The point about that data being valuable is valid though, so I propose that the default would be to use rtm.connect (better for most people anyway) and there is an option for using rtm.start, and in both cases the data is returned.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
Roach added a commit that referenced this issue Aug 23, 2017
* Added rtm.connect support

* updated docs

* updated gitignore

* Uncommented lines which were accidentally left commented

* Updated docs

* Removed ignored doc source files

* Fixed typo in method docs

* fixed line length

* updated rim start tests

* regenerated docs
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this issue Jun 18, 2019
* Added rtm.connect support

* updated docs

* updated gitignore

* Uncommented lines which were accidentally left commented

* Updated docs

* Removed ignored doc source files

* Fixed typo in method docs

* fixed line length

* updated rim start tests

* regenerated docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant