MessageEvent incorrectly references the Node global MessageEvent type. #2020

[varmil]

Summary

This pull request resolves #2020

Requirements (place an x in each [ ])

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @varmil to sign the Salesforce Inc. Contributor License Agreement.

[seratch]

@varmil Could you sign your CLA (see the above bot message)? Without that, we are unable to accept any external contributions 🙇

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (a7cc255) to head (d270fe6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2021   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files          37       37           
  Lines        9946     9946           
  Branches      633      633           
=======================================
  Hits         9114     9114           
  Misses        820      820           
  Partials       12       12           

Flag	Coverage Δ
cli-hooks	95.23% <ø> (ø)
cli-test	95.39% <ø> (ø)
oauth	77.39% <ø> (ø)
socket-mode	58.22% <ø> (ø)
web-api	96.87% <ø> (ø)
webhook	96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[varmil]

Thank you for your prompt confirmation. I have completed the CLA. Is this okay?

[seratch]

Yes, good to go! Other members in my team will be checking this PR soon. Thanks again for taking the time to fix this!

[filmaj]

Took me a bit to understand why this solution works, but it seems like references to MessageEvent inside message.ts refer to the built-in node MessageEvent interface and not the Slack one:

I will look to add a type test in a follow-up PR to catch this. Thank you!