Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: small refactor in views, jsdoc all view properties, add type tests #1820

Merged
merged 1 commit into from
Jun 14, 2024
Merged

types: small refactor in views, jsdoc all view properties, add type tests #1820

merged 1 commit into from
Jun 14, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jun 14, 2024

  • Small refactor to move shared View properties into an internal BaseView interface
  • JSDoc all the View things
  • Adds first type test file to the test repo (fixes types: add type tests via tsd #1740)

@filmaj filmaj added semver:patch enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` auto-triage-skip labels Jun 14, 2024
@filmaj filmaj added this to the types@2.13.0 milestone Jun 14, 2024
@filmaj filmaj requested a review from a team June 14, 2024 13:31
@filmaj filmaj self-assigned this Jun 14, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (f8d06ca) to head (63fa547).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1820   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          35       35           
  Lines        7742     7742           
  Branches      316      316           
=======================================
  Hits         6330     6330           
  Misses       1400     1400           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.07% <ø> (ø)
cli-test 53.80% <ø> (ø)
oauth 76.51% <ø> (ø)
socket-mode 59.41% <ø> (ø)
web-api 96.53% <ø> (ø)
webhook 95.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

WilliamBergamin
WilliamBergamin approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches 💯

@filmaj filmaj merged commit 893b836 into main Jun 14, 2024
21 checks passed
@filmaj filmaj deleted the view-jsdocs-and-type-tests branch June 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

Assignees

@filmaj filmaj

Labels
area:typescript issues that specifically impact using the package from typescript projects auto-triage-skip enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:patch
Projects
None yet
Milestone
types@2.13.0
Development

Successfully merging this pull request may close these issues.

types: add type tests via tsd
2 participants
@filmaj @WilliamBergamin