Fix #1426 IllegalStateException when deserializing message using conversations.history

[seratch]

This pull request resolves #1426

Category (place an x in each of the [ ])

• bolt (Bolt for Java)
• bolt-{sub modules} (Bolt for Java - optional modules)
• slack-api-client (Slack API Clients)
• slack-api-model (Slack API Data Models)
• slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
• slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

[codecov]

Codecov Report

Attention: Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.12%. Comparing base (0764bd8) to head (5901635).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../java/com/slack/api/util/json/GsonFileFactory.java	64.51%	4 Missing and 7 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1429      +/-   ##
============================================
- Coverage     73.14%   73.12%   -0.03%     
- Complexity     4375     4386      +11     
============================================
  Files           474      475       +1     
  Lines         14209    14243      +34     
  Branches       1438     1447       +9     
============================================
+ Hits          10393    10415      +22     
- Misses         2969     2973       +4     
- Partials        847      855       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WilliamBergamin]

This seems good 💯

Just for my own understanding, if the groups field is not an array then its content gets removed and if shares.public or shares.private are present then their reply_users fields are not arrays they also get removed?

[WilliamBergamin]

Not sure I understand this comment, do we still need it?

[seratch]

As mentioned below, if you run context.deserialize(jsonObject, File.class); within the deserialize method, it results in StackOverflowError because the same method is associated with the File.class. To let gson mechansim to run a different auto-binding process without stack overflow, I've added this sub class. This is internal hidden class, so you can rename it whenever you want to do so. Also, if you find a better solution to achive the same, please feel free to change this part. It won't be a breaking change because this class and the the code using it are hidden from users.