Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1179 Add message_blocks property to Attachement class #1181

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 7, 2023

This pull request resolves #1179

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model labels Jul 7, 2023
@seratch seratch added this to the 1.30.1 milestone Jul 7, 2023
@seratch seratch self-assigned this Jul 7, 2023
@seratch seratch merged commit ce33f1a into slackapi:main Jul 7, 2023
2 checks passed
@seratch seratch deleted the issue-1179-message_blocks branch July 7, 2023 11:40
seratch added a commit to seratch/java-slack-sdk that referenced this pull request Sep 19, 2023
seratch added a commit that referenced this pull request Sep 19, 2023
* Fix #1207 by correcting the typing introduced by #1181
* Run ./scripts/run_no_prep_tests.sh
@zubchenok
Copy link

this change causes exception. message_blocks of type LayoutBlock cannot be read, because there is no type field in message_blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message_blocks property to Attachement class
2 participants