Allow to work without activesupport concerns #84
Conversation
|
This broke the build, please check. |
|
Need to refactor tests. Will fix. Thanks. |
|
This is green, nice. So can we remove https://github.com/dblock/slack-ruby-bot/blob/master/slack-ruby-bot.gemspec#L19? Also needs a CHANGELOG entry. |
| @@ -4,6 +4,9 @@ | |||
| * [#54](https://github.com/dblock/slack-ruby-bot/pull/54): Improvements to Hook configuration - [@dramalho](https://github.com/dramalho). | |||
| * Your contribution here. | |||
|
|
|||
| ### 0.7.1 (7/7/2016) | |||
There was a problem hiding this comment.
Don't call a release, you're not making a release. This should be under 0.8.1 (Next). Also please prefix it with a link to the PR like the other lines. I would just say "Removed dependency on ActiveSupport", logger is TMI.
There was a problem hiding this comment.
Thanks. Sorry, my first contribution to open source.
| @@ -4,7 +4,8 @@ | |||
| * [#75](https://github.com/dblock/slack-ruby-bot/issues/75): Guarantee order of command evaluation - [@dblock](https://github.com/dblock). | |||
| * [#76](https://github.com/dblock/slack-ruby-bot/issues/76): Infinity error when app disabled - [@slayershadow](https://github.com/SlayerShadow). | |||
| * [#81](https://github.com/dblock/slack-ruby-bot/pull/81): Remove bundler dependency - [@derekddecker](https://github.com/derekddecker). | |||
| * Your contribution here. | |||
There was a problem hiding this comment.
Put this back please for the next person.
|
Merged. |
|
FYI This broke logging level separation between slack-ruby-client and slack-ruby-bot, see https://github.com/dblock/slack-ruby-bot/issues/85. |
No description provided.