-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add brief migration guide #260
Conversation
a61f8c4
to
9b37a82
Compare
9b37a82
to
73ceea5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start!
MIGRATION.md
Outdated
|
||
## Migrating to slack-ruby-bot-server | ||
Overview: | ||
- Create a new Slack App as [advised by Slack](https://api.slack.com/legacy/custom-integrations/legacy-tokens#migrating-from-legacy). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing. I think we should tell users to go through the tutorial/setup of slack-ruby-bot-server as in that doc, then copy command classes, then do the workflow that you suggest. And explain what happens when you do that and the fact that other teams can install the bot too then, which may not be what you want (and needs to be prevented).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually a little confused by Slack itself. If I understood correctly, slack-ruby-bot-server requires the latest Slack Apps, but there are also legacy tokens AND class Slack Apps, both with subtly different migration strategies on the Slack end. Did I get that right, and should I gloss over this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say gloss over this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Any more comments?
I merged this, thank you. |
Fixes #252.
I may not have the opportunity to verify this flow for some time, if anyone has tried it, do let me know if it works / there are any issues!