Handle commands with spaces when using Controller #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed a use-case when first designing the MVC classes. Sometimes people design commands like this:
If someone sent a command with spaces to the controller it would fail to match any known method.
So, the Controller class was augmented to support this. Any method names that contain embedded underscores '_' will now generate a command matcher with spaces. When that command matches a route and we try to call the corresponding controller method, the command is downcased and converted to a
method_name_with_spaces
.