Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block_object typo and refactor to use static type #762

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

longngn
Copy link
Contributor

@longngn longngn commented Jul 15, 2020

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

@longngn
Copy link
Contributor Author

longngn commented Jul 24, 2020

@nlopes Hi, could you review this PR? The mrkdown typo is pretty severe and could affect many use cases. Thanks!

@kanata2
Copy link
Member

kanata2 commented Aug 18, 2020

Thanks!

@kanata2
Copy link
Member

kanata2 commented Aug 18, 2020

@longngn I overlooked API breaking changes. So I reverted it, and will submit new PR which fixes a typo mrkdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants