Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Slack AI & Assistants Compatibility #1331

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

MattDavisRV
Copy link
Contributor

@MattDavisRV MattDavisRV commented Oct 8, 2024

@MattDavisRV
Copy link
Contributor Author

This PR resolves issue 1326.

@lorenzoaiello lorenzoaiello added enhancement RTM API about Real Time Messaging API Web API labels Oct 14, 2024
Copy link
Contributor

@lorenzoaiello lorenzoaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MattDavisRV , thanks for the PR! I've got some minor feedback items I added.

It also looks like you may have included some new events, which while very much appreciated, may not be related to the Assistant Events.

Could you please submit these changes in a different PR so we can keep PRs scoped to a single issue or share the documentation where they are required for the Assistant functionality?

assistant.go Show resolved Hide resolved
assistant.go Outdated Show resolved Hide resolved
assistant.go Outdated Show resolved Hide resolved
assistant.go Show resolved Hide resolved
@lorenzoaiello lorenzoaiello added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Oct 14, 2024
@MattDavisRV
Copy link
Contributor Author

@lorenzoaiello, sorry about the initially cluttered PR, I didn't look at the changed files and I'm unsure how all of the additional changes were added in. I've cleaned up the PR to only be my changes.

I've also added in an additional change for the Section Block that was added due to the AI changes. I was going to submit an additional PR with it, but I decided to add it in here.

@lorenzoaiello
Copy link
Contributor

@MattDavisRV , can you please resolve the conflicts?

@MattDavisRV
Copy link
Contributor Author

@lorenzoaiello all set, I refactored my tests, it looks like i can't use a handler function with form variables, I noticed other tests were using the standard "ok handler", so I switched to that. All tests are passing now.

@lorenzoaiello lorenzoaiello removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Oct 23, 2024
@lorenzoaiello lorenzoaiello self-requested a review October 23, 2024 23:11
@lorenzoaiello lorenzoaiello self-assigned this Oct 23, 2024
@MattDavisRV
Copy link
Contributor Author

Hey @lorenzoaiello, anything else I need to do here to get this merged in?

@lorenzoaiello lorenzoaiello changed the title Slack AI & Assistants Compatibility feat: Slack AI & Assistants Compatibility Nov 6, 2024
@lorenzoaiello lorenzoaiello merged commit 00d0e9a into slack-go:master Nov 6, 2024
7 checks passed
lorenzoaiello pushed a commit that referenced this pull request Nov 12, 2024
This is a fix for [PR
1331](#1331), which I mistakenly
removed the channel_id parameter from the API request during feedback.

Without channel_id provided, the call always returns
`invalid_arguments`.
gautamr95 pushed a commit to pylon-labs/slack that referenced this pull request Dec 13, 2024
…k-go#1344)

This is a fix for [PR
1331](slack-go#1331), which I mistakenly
removed the channel_id parameter from the API request during feedback.

Without channel_id provided, the call always returns
`invalid_arguments`.
gautamr95 pushed a commit to pylon-labs/slack that referenced this pull request Dec 13, 2024
…k-go#1344)

This is a fix for [PR
1331](slack-go#1331), which I mistakenly
removed the channel_id parameter from the API request during feedback.

Without channel_id provided, the call always returns
`invalid_arguments`.
gautamr95 pushed a commit to pylon-labs/slack that referenced this pull request Dec 13, 2024
…k-go#1344)

This is a fix for [PR
1331](slack-go#1331), which I mistakenly
removed the channel_id parameter from the API request during feedback.

Without channel_id provided, the call always returns
`invalid_arguments`.
gautamr95 pushed a commit to pylon-labs/slack that referenced this pull request Dec 13, 2024
…k-go#1344)

This is a fix for [PR
1331](slack-go#1331), which I mistakenly
removed the channel_id parameter from the API request during feedback.

Without channel_id provided, the call always returns
`invalid_arguments`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement RTM API about Real Time Messaging API Web API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants