-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Slack AI & Assistants Compatibility #1331
feat: Slack AI & Assistants Compatibility #1331
Conversation
This PR resolves issue 1326. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MattDavisRV , thanks for the PR! I've got some minor feedback items I added.
It also looks like you may have included some new events, which while very much appreciated, may not be related to the Assistant Events.
Could you please submit these changes in a different PR so we can keep PRs scoped to a single issue or share the documentation where they are required for the Assistant functionality?
…ram, not currently used by Slack
@lorenzoaiello, sorry about the initially cluttered PR, I didn't look at the changed files and I'm unsure how all of the additional changes were added in. I've cleaned up the PR to only be my changes. I've also added in an additional change for the Section Block that was added due to the AI changes. I was going to submit an additional PR with it, but I decided to add it in here. |
@MattDavisRV , can you please resolve the conflicts? |
@lorenzoaiello all set, I refactored my tests, it looks like i can't use a handler function with form variables, I noticed other tests were using the standard "ok handler", so I switched to that. All tests are passing now. |
Hey @lorenzoaiello, anything else I need to do here to get this merged in? |
This is a fix for [PR 1331](#1331), which I mistakenly removed the channel_id parameter from the API request during feedback. Without channel_id provided, the call always returns `invalid_arguments`.
Added new function for Slack AI & Assistants, information can be found here: https://api.slack.com/docs/apps/ai New Events: https://api.slack.com/events/assistant_thread_started https://api.slack.com/events/assistant_thread_context_changed New API Calls: https://api.slack.com/methods/assistant.threads.setStatus https://api.slack.com/methods/assistant.threads.setSuggestedPrompts https://api.slack.com/methods/assistant.threads.setTitle Tests have been added and pass all checks via `make pr-prep`.
…k-go#1344) This is a fix for [PR 1331](slack-go#1331), which I mistakenly removed the channel_id parameter from the API request during feedback. Without channel_id provided, the call always returns `invalid_arguments`.
Added new function for Slack AI & Assistants, information can be found here: https://api.slack.com/docs/apps/ai New Events: https://api.slack.com/events/assistant_thread_started https://api.slack.com/events/assistant_thread_context_changed New API Calls: https://api.slack.com/methods/assistant.threads.setStatus https://api.slack.com/methods/assistant.threads.setSuggestedPrompts https://api.slack.com/methods/assistant.threads.setTitle Tests have been added and pass all checks via `make pr-prep`.
…k-go#1344) This is a fix for [PR 1331](slack-go#1331), which I mistakenly removed the channel_id parameter from the API request during feedback. Without channel_id provided, the call always returns `invalid_arguments`.
Added new function for Slack AI & Assistants, information can be found here: https://api.slack.com/docs/apps/ai New Events: https://api.slack.com/events/assistant_thread_started https://api.slack.com/events/assistant_thread_context_changed New API Calls: https://api.slack.com/methods/assistant.threads.setStatus https://api.slack.com/methods/assistant.threads.setSuggestedPrompts https://api.slack.com/methods/assistant.threads.setTitle Tests have been added and pass all checks via `make pr-prep`.
…k-go#1344) This is a fix for [PR 1331](slack-go#1331), which I mistakenly removed the channel_id parameter from the API request during feedback. Without channel_id provided, the call always returns `invalid_arguments`.
Added new function for Slack AI & Assistants, information can be found here: https://api.slack.com/docs/apps/ai New Events: https://api.slack.com/events/assistant_thread_started https://api.slack.com/events/assistant_thread_context_changed New API Calls: https://api.slack.com/methods/assistant.threads.setStatus https://api.slack.com/methods/assistant.threads.setSuggestedPrompts https://api.slack.com/methods/assistant.threads.setTitle Tests have been added and pass all checks via `make pr-prep`.
…k-go#1344) This is a fix for [PR 1331](slack-go#1331), which I mistakenly removed the channel_id parameter from the API request during feedback. Without channel_id provided, the call always returns `invalid_arguments`.
Added new function for Slack AI & Assistants, information can be found here: https://api.slack.com/docs/apps/ai
New Events:
https://api.slack.com/events/assistant_thread_started
https://api.slack.com/events/assistant_thread_context_changed
New API Calls:
https://api.slack.com/methods/assistant.threads.setStatus
https://api.slack.com/methods/assistant.threads.setSuggestedPrompts
https://api.slack.com/methods/assistant.threads.setTitle
Tests have been added and pass all checks via
make pr-prep
.