Add support for team_id in UserGroup functions #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 How can we get the Github tests to run here? |
lfventura
added a commit
to lfventura/slack-go
that referenced
this pull request
May 26, 2023
lfventura
added a commit
to lfventura/slack-go
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
team_idin all of theusergroupsfunctions, so they can work in Slack Enterprise Grid with multiple workspaces. For reference see https://api.slack.com/enterprise/apps/changes-apis#methodsI tried to stick to the established pattern of using Options variadic parameters to pass the team_id (together with other optional arguments). I don't think the changes affect existing clients using a single workspace.
I've tested all modified functions against the Slack API in an Enterprise Grid instance.