Handle consecutive spaces when copying and pasting #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhchen
force-pushed
the
jc-whitespace
branch
from
79b6ed6 to
2e48505
Compare
jhchen
force-pushed
the
jc-whitespace
branch
from
2e48505 to
f2f3480
Compare
luin
changed the title
skovalyov
reviewed
Dec 11, 2024
| @@ -370,7 +370,8 @@ function convertHTML( | |||
| return blot.html(index, length); | |||
| } | |||
| if (blot instanceof TextBlot) { | |||
| return escapeText(blot.value().slice(index, index + length)); | |||
| const escapedText = escapeText(blot.value().slice(index, index + length)); | |||
| return escapedText.replaceAll(' ', ' '); | |||
There was a problem hiding this comment.
Just curious, why was it necessary? I got an error after update because of this. The text I get from a quill instance using event.editor.getSemanticHTML() now returns instead of all spaces resulting in wrong behavior when I pass this string to another service, which renders it in PDF.
There was a problem hiding this comment.
We are seeing the on copy/pasting into the editor. We're using PrimeNG 17.18.12 with quill 2.0.3. We reverted to quill 2.0.2 because of this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.