Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build when grunt is not installed globally #389

Merged
merged 1 commit into from
Jun 8, 2015
Merged

Fix build when grunt is not installed globally #389

merged 1 commit into from
Jun 8, 2015

Conversation

ooflorent
Copy link
Contributor

If you don"t have grunt-cli globally installed, the build will currently fail.
This PR fixes this.

@jhchen
Copy link
Member

jhchen commented Jun 8, 2015

Can you be more specific about what this PR fixes? grunt dist will still "fail" without ./node_modules/.bin being added to the path.

@ooflorent
Copy link
Contributor Author

It solves npm run scripts. npm automatically adds .bin to the path.
Without grunt-cli being globally installed, you can now npm install and also npm run prepublish, npm test, etc

@jhchen jhchen merged commit 4c5d125 into slab:develop Jun 8, 2015
@ooflorent
Copy link
Contributor Author

Thanks!

@jhchen
Copy link
Member

jhchen commented Jun 8, 2015

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ooflorent @jhchen