Fix checkbox not checkable on Firefox #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DokaRus
pushed a commit
to DokaRus/devextreme-quill
that referenced
this pull request
Mar 25, 2021
Fix checkbox not checkable on Firefox (cherry picked from commit 1f0530a)
DokaRus
added a commit
to DevExpress/devextreme-quill
that referenced
this pull request
Mar 26, 2021
* Merge pull request slab#3223 from luin/ignore-nested-quill-mutations Ignore mutations happens in nested Quill instance (cherry picked from commit 8ce3ee3) * Merge pull request slab#3272 from luin/firefox-bullet Header/paragraph doesn't reset list numbering in Firefox (cherry picked from commit eeb976e) * allow list completion on lists and headers (cherry picked from commit a6911aa) * fix arrow keying past list item - in chrome it take two left arrows to go to prev list item - in firefox ctrl+left does not work (cherry picked from commit 9d16aa5) * fix breaking list items Without this a string with no space on a line will cause the break to occur after the bullet but with it a string with spaces may not break at the space. The latter is much more common and also the choice Paper makes (cherry picked from commit 232b6f4) * Merge branch 'fix-cut-format' * Merge pull request slab#3293 from quilljs/firefox-checkbox Fix checkbox not checkable on Firefox (cherry picked from commit 1f0530a) Co-authored-by: Jason Chen <jhchen7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause is items with
display: contentsdon't have correct frames on Firefox, so the event listener attached to the checkbox won't work.This PR only applies the
display: contentsto ordered and bullet list. It worth noticing thatdisplay: contentswas introduced to fix the following issues:After this change, regressions of the above issues are expected but only for the checkboxes.
Also, after some tests,
display: contentsintroduces a side effect on Safari that pressing command + left arrow on the first line of a list item will move the caret to the beginning of the editor. Not sure the reason though.Test plan: